Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/configNetwork.py PEP8 clean
......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
Run through autobuild.sh.
pydiff reports 10 differences, all are acceptable. The detailed reports is as
follow:
10 difference(s)
first file: configNetworko.py
second file: configNetwork.py
((20, ('subprocess', None)), ('20 + -', None))
((20, ('os', None)), ('20 + -', None))
((20, ('re', None)), ('20 + -', None))
((20, ('traceback', None)), ('20 + -', None))
(('20 +', None), (21, Import([('subprocess', None)])))
(('20 +', None), (22, Import([('os', None)])))
(('20 +', None), (23, Import([('re', None)])))
(('20 +', None), (24, Import([('traceback', None)])))
((457,
"If([(Compare(Name('bonding'), [('not in',
CallFunc(Getattr(CallFunc(Getattr(CallFunc(Name('open'),
[Const('/sys/class/net/bonding_masters')], None, None), 'read'), [], None,
None), 'split'), [], None, None))]),
Stmt([Discard(CallFunc(Getattr(CallFunc(Name('open'),
[Const('/sys/class/net/bonding_masters'), Const('w')], None, None), 'write'),
[Mod((Const('+%s\\n'), Name('bonding')))], None, None))]))], None)"),
(481,
"Assign([AssName('bondMastersPath', 'OP_ASSIGN')],
Const('/sys/class/net/bonding_masters'))"))
(('457 +', None),
(482,
If([(Compare(Name('bonding'), [('not in',
CallFunc(Getattr(CallFunc(Getattr(CallFunc(Name('open'),
[Name('bondMastersPath')], None, None), 'read'), [], None, None), 'split'), [],
None, None))]), Stmt([Discard(CallFunc(Getattr(CallFunc(Name('open'),
[Name('bondMastersPath'), Const('w')], None, None), 'write'),
[Mod((Const('+%s\n'), Name('bonding')))], None, None))]))], None)))
First 8 differences are about splitting long import into pieces. Last two are
about defining a variable for a long string. They are all acceptable.
--
To view, visit http://gerrit.ovirt.org/7758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02be4c0cdb1868a8518a73e22dfb77adedc08f3f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
