Francesco Romani has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ ......................................................................
Patch Set 1: Code-Review+1 TL;DR: +1 I'm ok as long as we all settle in one direction. I see the shift is towards __repr__ and I don't have strong objections. +++ I'm OK but not completely sold, here's why: Reading the python docs, I think on average the actual output is more suitable for __str__ than __repr__ (e.g. we rarely if ever attempt to produce an output that "If at all possible, this should look like a valid Python expression that could be used to recreate an object with the same value"). I guess we often fall short of "if at all possible" :) -- To view, visit https://gerrit.ovirt.org/48865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fd724e32dfde1ca484343730f2e55c37a59fdf3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
