Petr Horáček has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48830/1/vdsm_hooks/ovs/ovs_before_network_setup_ip.py File vdsm_hooks/ovs/ovs_before_network_setup_ip.py: Line 35: Line 36: Line 37: iproute2 = Iproute2() Line 38: Line 39: IPConfig = namedtuple('IPConfig', ['top_dev', 'ipv4', 'ipv6', 'port', > namedTuples are cool but evil. Ondrej has tried very hard to get rid of the ipv4 model is already used here, i'd like to use Bridge model, but it requires passing configurator argument and does not fit well with this. would you mind if i change it into a class in a later patch? to have this whole branch merged asap Line 40: 'blocking_dhcp']) Line 41: Line 42: Line 43: def _get_ipv4_model(attrs): -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
