Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
......................................................................
Patch Set 5:
Francesco, once we have exceptions for any response, we don't need the response
module.
Virt code will work like storage - you will fail the operation in the some
layer, deep as needed, there will be no need to return a response for every
error, only on success.
All requests will be run via a top error handler doing:
try:
return method(args)
except VdsmException as e:
return e.response()
except Exception:
return internal error
--
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
