Ido Barkan has uploaded a new change for review. Change subject: net: Remove reporting of bond custom options from RunningConfig ......................................................................
net: Remove reporting of bond custom options from RunningConfig This reporting is ignored in engine, is not symmetric to network custom properties as VDSM does not report such a field on a network and also deepens the reliance of netinfo on RunningConfig. Since we want to remove this dependency soon, this is one step in thus direction. Change-Id: I5863d67b2b2b9ce15cee9c447983d3ba2e0f23ce Signed-off-by: Ido Barkan <[email protected]> --- M lib/vdsm/netinfo.py 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/49081/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index cb185b9..3e1f065 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -524,15 +524,6 @@ info['cfg']['BONDING_OPTS'] = _bondOptsForIfcfg(info['opts']) -def _bondCustomOpts(dev, devinfo, running_config): - """Add custom bonding options read from running_config.""" - if dev.name in running_config.bonds: - for option in running_config.bonds[dev.name]['options'].split(): - if option.startswith('custom='): - devinfo['opts']['custom'] = option.split('=', 1)[1] - break - - def _vlaninfo(link): return {'iface': link.device, 'vlanid': link.vlanid} @@ -801,7 +792,6 @@ dhcpv6_ifaces)) if dev.isBOND(): _bondOptsCompat(devinfo) - _bondCustomOpts(dev, devinfo, running_config) for network_name, network_info in six.iteritems(networking['networks']): if network_info['bridged']: -- To view, visit https://gerrit.ovirt.org/49081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5863d67b2b2b9ce15cee9c447983d3ba2e0f23ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
