Piotr Kliczewski has posted comments on this change. Change subject: stomp: message tracking do not clean properly ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48616/3/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 325: try: Line 326: destination = self._req_dest[response_id] Line 327: del self._req_dest[response_id] Line 328: except KeyError: Line 329: # we could have no reply-to or we could send events (no message id) > what about: The idea looks great, will push new patch for it. Line 330: pass Line 331: Line 332: try: Line 333: connections = self._sub_map[destination] -- To view, visit https://gerrit.ovirt.org/48616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
