Nir Soffer has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags ......................................................................
Patch Set 5: Code-Review+1 (1 comment) Nice! https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh File contrib/rhev_build.sh: Line 1: echo 'Please run this script from vdsm main folder' Line 2: echo '============================================' Line 3: Line 4: make distclean I would add empty line between the commands for extra clearity. Line 5: ./autogen.sh \ Line 6: --system \ Line 7: --with-smbios-manufacturer='Red Hat' \ Line 8: --with-smbios-osname='RHEV Hypervisor' \ -- To view, visit https://gerrit.ovirt.org/49001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
