Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies ......................................................................
Patch Set 18: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41849/18/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 219: FileVolumeMetadata.file_setrw(volPath, rw) Maybe use : cls.metadataClass instead of FileVolumeMetadata -- To view, visit https://gerrit.ovirt.org/41849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48e05ef7168ab835d31914e05f3abd969b6552b1 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches