Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/48404/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1561: return response.error('migCancelErr') Line 1562: finally: Line 1563: self._guestCpuLock.release() Line 1564: Line 1565: def _serialConsole(self): > please use _getSerialConsole or _findSerialConsole() like we do elsewhere i Done (originally wanted to be consistent with _customDevices immediately below). Line 1566: """ Line 1567: Return serial console device. Line 1568: If no serial console device is available, return 'None'. Line 1569: """ -- To view, visit https://gerrit.ovirt.org/48404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
