Nir Soffer has posted comments on this change. Change subject: build: Cleanup conditionals in the build system ......................................................................
Patch Set 18: (2 comments) https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in File vdsm.spec.in: Line 46 Line 47 Line 48 Line 49 Line 50 > :) Can you explain when this should be used? if it is never can be true, lets remove this and the koji_build that is used only for this check. Line 10: %global snlk_user @SNLKUSER@ Line 11: %global cdrom_group @CDROMGROUP@ Line 12: Line 13: # Build types Line 14: %global koji_build @KOJI_BUILD@ > So if it "says if to install vhostmd" why the name do not reflect its inten Lets improve the name in another patch, we are trying to cleanup the logic here. Line 15: Line 16: # Features Line 17: %global with_gluster_mgmt @GLUSTER_MGMT@ Line 18: %global with_hooks @HOOKS@ -- To view, visit https://gerrit.ovirt.org/48446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Korren <bkor...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
