Dan Kenigsberg has submitted this change and it was merged. Change subject: mkimage: setup right permissions before mkisofs ......................................................................
mkimage: setup right permissions before mkisofs We don't want to depend on the 'childUmask' argument of cpopen anymore, so that argument could be dropped in future release, to make the interface of cpopen identical to the one of the standard subprocess module. The 'childUmask' argument was added to make sure that the iso image we create has the right permissions right from the file creation, to avoid possible information leak. We can reach the same goal by preparing one hollow file with the right attributes on the same path mkisofs will use. mkisofs will truncate the (already empty) content of the file we prepared, and keep the other attributes. There are no planned change in functionality. Change-Id: Ibc971a39ae2a8eaf7af934bb0922647e4676d03f Bug-Url: https://bugzilla.redhat.com/1278414 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/48538 Reviewed-by: Nir Soffer <[email protected]> Continuous-Integration: Jenkins CI --- M vdsm/mkimage.py 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/48538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc971a39ae2a8eaf7af934bb0922647e4676d03f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
