Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/48881/10/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 435: DISK_TYPE.BLOCK: 'dev', Line 436: DISK_TYPE.NETWORK: 'name' Line 437: } Line 438: return ("./devices/disk/source[@%s='%s']" % Line 439: (source_key[self.diskType], self.path)) > All the changes except making _xpath private and adding is_attached_to are Done Line 440: Line 441: def is_attached_to(self, xml_string): Line 442: dom = ET.fromstring(xml_string) Line 443: return bool(dom.findall(self._xpath)) Line 435: DISK_TYPE.BLOCK: 'dev', Line 436: DISK_TYPE.NETWORK: 'name' Line 437: } Line 438: return ("./devices/disk/source[@%s='%s']" % Line 439: (source_key[self.diskType], self.path)) > Now I found how the \ sneank in, you added it in https://gerrit.ovirt.org/4 Done Line 440: Line 441: def is_attached_to(self, xml_string): Line 442: dom = ET.fromstring(xml_string) Line 443: return bool(dom.findall(self._xpath)) -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
