Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: metadata write utils ......................................................................
Patch Set 19: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41847/19/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 651: raise se.VolumeMetadataWriteError("%s: %s" % (metaId, e)) Line 652: Line 653: @classmethod Line 654: def __putMetadata(cls, metaId, meta): Line 655: cls.MetadataClass._putMetadata(metaId, meta) MetadataClass -> metadataClass Line 656: Line 657: @classmethod Line 658: def createMetadata(cls, metaId, meta): Line 659: cls.__putMetadata(metaId, meta) https://gerrit.ovirt.org/#/c/41847/19/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 414: self.oop.os.unlink(metaPath) Line 415: Line 416: @classmethod Line 417: def __putMetadata(cls, metaId, meta): Line 418: FileVolumeMetadata._putMetadata(metaId, meta) > Why is it different from Block volume ? There you used cls.MetadataClass._p Yes, should use same code - actually, you can move this up to Volume, since both methods delegate to cls.metadataClass_putMetadata() Line 419: Line 420: @classmethod Line 421: def createMetadata(cls, metaId, meta): Line 422: cls.__putMetadata(metaId, meta) -- To view, visit https://gerrit.ovirt.org/41847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia245c589ea6bc2cf9ac1b2b59b9073d1b5fc9595 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
