Nir Soffer has uploaded a new change for review.

Change subject: guestagent: Rename connect() to start()
......................................................................

guestagent: Rename connect() to start()

GuestAgent was started by invoking connect() and stopped by invoking
stop().  We can rename stop() to disconnect(), but it seems that it is
more clear to rename connect() to start(). This conforms with other
subsystems implementing this interface.

Change-Id: I649075cf67cb0db4e1aede14586d0b26f2bf59b4
Signed-off-by: Nir Soffer <[email protected]>
---
M vdsm/virt/guestagent.py
M vdsm/virt/vm.py
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/49342/1

diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py
index d7c0d25..cd9a434 100644
--- a/vdsm/virt/guestagent.py
+++ b/vdsm/virt/guestagent.py
@@ -156,7 +156,7 @@
     def diskMappingHash(self):
         return self._diskMappingHash
 
-    def connect(self):
+    def start(self):
         self.log.info("Starting connection")
         self._prepare_socket()
         self._channelListener.register(
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f07f55e..f22f3d2 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1767,7 +1767,7 @@
         self._guestEventTime = self._startTime
         sampling.stats_cache.add(self.id)
         try:
-            self.guestAgent.connect()
+            self.guestAgent.start()
         except Exception:
             self.log.exception("Failed to connect to guest agent channel")
 


-- 
To view, visit https://gerrit.ovirt.org/49342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I649075cf67cb0db4e1aede14586d0b26f2bf59b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to