Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 155: for name in conn.listDefinedDomains(): Line 156: _add_vm(conn, vms, conn.lookupByName(name)) Line 157: Line 158: for vmid in conn.listDomainsID(): Line 159: _add_vm(conn, vms, conn.lookupByID(vmid)) > Why do we need lookup both by name and by id? Very good solution... Line 160: Line 161: return {'status': doneCode, 'vmList': vms} Line 162: Line 163: Line 155: for name in conn.listDefinedDomains(): Line 156: _add_vm(conn, vms, conn.lookupByName(name)) Line 157: Line 158: for vmid in conn.listDomainsID(): Line 159: _add_vm(conn, vms, conn.lookupByID(vmid)) > I see, so we have race - vm returned from listDefinedDomains() may be up wh Yes, This was the assumption in vmware as well. Line 160: Line 161: return {'status': doneCode, 'vmList': vms} Line 162: Line 163: -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
