Ramesh N has posted comments on this change. Change subject: gluster: fix brick devices are created with incorrect data alignment ......................................................................
Patch Set 2: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/47959/2/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 63: DEFAULT_MOUNT_OPTIONS Looks like default mount options are not at all used while mounting the device. Line 244: peSize as per red hat storage admin guide https://access.redhat.com/documentation/en-US/Red_Hat_Storage/3.1/html/Administration_Guide/Brick_Configuration.html, Pesize should be (stripe unit size * number of data disks). Line 259: poolDataSize = poolDataSize - (1024) I am not sure why u need this. Can u explain the bug little bit more? Line 265: metaDataSize = (metaDataSize - (metaDataSize % alignment)) Is it required to be aligned with raid stripe size?. -- To view, visit https://gerrit.ovirt.org/47959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58cc322cb5140de2d2006d59b4c1dceaba2e5968 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Manoj Pillai <mpil...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
