Francesco Romani has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug ......................................................................
Patch Set 19: Code-Review-1 too quick. I'm still happy with this patch per se, but I want to avoid attributes missing from the base class. Marcin, please let's do one final step: - post a simple patch adding xpath property to base class (devices.Core), doing the right thing (e.g. raise NotImplementedError like is_attached_to in the next patch) - reshuffle this series to have this patch depend on the new one added This way you can leave this patch unchanged, no score is lost and code is more consistent and less surprising. -- To view, visit https://gerrit.ovirt.org/48473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
