Nir Soffer has posted comments on this change. Change subject: vm: snapshot - enabling memory snapshot for diskless VM ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49535/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3137 Line 3138 Line 3139 Line 3140 Line 3141 This allows memory snapshot without any disks - does this snapshot make sense? can you preview this snapshot? When using cinder disk, the memory snapshot is stored on another domain. Do we save this vm in the ovf store of both domains? What happens when you detach the domain containing the memory snapshot? Having vm with memory snapshots on another domain (the user have no control on this domain) seems like unwanted behavior. -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
