Ido Barkan has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics ......................................................................
Patch Set 10: Code-Review-1 (6 comments) only minor stuff https://gerrit.ovirt.org/#/c/49390/10/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 242: e.errno == errno.EINVAL or e.errno == errno.EPER this can be more elegantly written as: if e.errno in (errno.EINVAL, errno.EPERM): Line 505: opt_num_val replace this with return Line 507: opt_num_val = replace this with return https://gerrit.ovirt.org/#/c/49390/10/lib/vdsm/tool/dump_bonding_opts.py File lib/vdsm/tool/dump_bonding_opts.py: Line 93: _bond_opts naming: context managers are usually named as nouns. like: bond_device. this makes clear that there is a certain resource that is created and the cleaned for the purpose of the context. https://gerrit.ovirt.org/#/c/49390/10/tests/netinfoTests.py File tests/netinfoTests.py: Line 338: exist exists Line 348: exist exists -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
