Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fail if Password doesn't match
......................................................................
Patch Set 3: (1 inline comment)
About:
> One more thought; do we have to worry about how
> password_check() behaves on older ovirt-nodes?
I have checked some previous code and I cannot see any problem.
Thanks
Douglas
....................................................
File vdsm_reg/engine.py.in
Line 230: compatPort, sslPort = compatiblePort(enginePort)
Line 231:
Line 232: # Show error if the password informed by user doesn't match
Line 233: if self.pw_resp == PASSWORD_DOESNT_MATCH and
len(self.root_password_1.value()) > 0 or \
Line 234: self.pw_resp == PASSWORD_DOESNT_MATCH and
len(self.root_password_2.value()) > 0:
We cannot skip. The ovirt node API returns 1 in case users don't want to set
the password:
def password_check(password_1, password_2, min_length=1):
if len(password_1) is 0 and min_length is not 0:
return (1, "\n\n\n\n\n")
Line 235:
Line 236: # Required since we now are verifying if the Confirm
Password were filled
Line 237: # and Password field not
Line 238: if self.pw_pcheck_msg.strip("\n") == "":
--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Joey Boggs <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
