Martin Sivák has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49387/5/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3658: def startMonitoringDomain(self, sdUUID, hostID, options=None): Line 3659: with rmanager.acquireResource(STORAGE, HSM_DOM_MON_LOCK, Line 3660: rm.LockType.exclusive): Line 3661: # Note: We cannot raise here StorageDomainIsMemberOfPool, as it Line 3662: # will break old hosted engine agent. > I would explain more why it can break HE agent .. for me the comment doesn' The old agent does not know how to handle the new exception. Line 3663: self.domainMonitor.startMonitoring(sdUUID, int(hostID), False) Line 3664: Line 3665: @deprecated Line 3666: @public -- To view, visit https://gerrit.ovirt.org/49387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99555b230dfdab41384af0461e4b30c590b669b9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
