Francesco Romani has posted comments on this change. Change subject: virt: add run_async helper ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/49570/1/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 169: def test_ignores_error(self): Line 170: def helper(): Line 171: raise RuntimeError("Async() doesn't care") Line 172: Line 173: error = utils.run_async(helper) > run_async doesn't return anything. Technically, it should return None, so t Right, this is a relic of a past version Line 174: self.assertEqual(error, None) Line 175: Line 176: Line 177: class RunAsyncThrottledTests(TestCaseBase): Line 179: def setUp(self): Line 180: self.sem = threading.BoundedSemaphore(1) Line 181: Line 182: def test_do(self): Line 183: > Please use less blank lines (IMHO none are needed inside such short methods Right, sneaked in between revisions. Line 184: done = threading.Event() Line 185: Line 186: def helper(): Line 187: done.set() -- To view, visit https://gerrit.ovirt.org/49570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
