Shahar Havivi has posted comments on this change. Change subject: v2v: add try/except to get_external_vms ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py File vdsm/v2v.py: Line 175: e.message, vm.XMLDesc(0)) Line 176: continue Line 177: try: Line 178: _add_networks(root, params) Line 179: except libvirt.libvirtError as e: > My point is that libvirtError is never raised inside _add_networks or _add_ sorry good point! it should be ParseError... Line 180: logging.error('error reading network configuration: %s', e) Line 181: continue Line 182: try: Line 183: _add_disks(root, params) -- To view, visit https://gerrit.ovirt.org/49507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
