Nir Soffer has posted comments on this change.

Change subject: vm: adding xpath property to device Base class
......................................................................


Patch Set 2:

Francesco, what is wrong with:

 >>> Device()._xpath
 Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
 AttributeError: Device instance has no attribute '_xpath'

Python alreay implemented that for us, we don't have to implement
anything to understand this issue.

This error is bad only for required attributes which we do not
initialize - this is separate issue.

-- 
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a7989cde44da0f756d48ae139fba47e524a40b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to