Dan Kenigsberg has posted comments on this change.
Change subject: Make netinfo.py PEP8 clean
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/netinfo.py
Line 187: def getVlanBondingNic(bridge):
Line 188: """Return the (vlan, bonding, nics) tupple that belongs to
bridge."""
Line 189:
Line 190: if bridge not in bridges():
Line 191: raise ValueError('unknown bridge %s' % bridge)
why? using tuple as an arg to % is holier, regardless of the exception type.
Line 192: vlan = bonding = ''
Line 193: nics = []
Line 194: for iface in os.listdir('/sys/class/net/' + bridge + '/brif'):
Line 195: if iface in vlans():
--
To view, visit http://gerrit.ovirt.org/7922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3ee6348a0a9eb4366b1571ab5883deba9b40d0a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
