Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support ......................................................................
Patch Set 14: Code-Review-1 (2 comments) -1 for visibility https://gerrit.ovirt.org/#/c/48672/14/vdsm/v2v.py File vdsm/v2v.py: Line 647: if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT: Line 648: raise Line 649: seen = set() Line 650: for name in conn.listDefinedDomains(): Line 651: seen.add(name) Is name unique? If not, we should use vm id in seen - first get vms by id, then get vms by name, check if vm id already in seen. Line 652: vm = conn.lookupByName(name) Line 653: yield vm Line 654: for vmid in conn.listDomainsID(): Line 655: vm = conn.lookupByID(vmid) Line 657: continue Line 658: yield vm Line 659: Line 660: Line 661: def _add_vm(conn, vms, vm): > next time please split this (welcome) refactor in a separate patch. Why not split now? The refactor can be easily tested using the unit tests. Line 662: params = {} Line 663: try: Line 664: _add_vm_info(vm, params) Line 665: try: -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
