Adam Litke has posted comments on this change. Change subject: VolumeMetadata: metadata write utils ......................................................................
Patch Set 28: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/41847/28/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 296: def formatMetadata(cls, meta): Line 297: return cls.metadataClass.formatMetadata(meta) Line 298: Line 299: @classmethod Line 300: def _putMetadata(cls, metaId, meta): __putMetadata was renamed to _putMetadata in the VolumeMetadata* classes because otherwise the Volume* classes could not call it. Changing it here definitely makes the tests nicer and the parity of names between the two locations is nicer. The tradeoff is the need to modify all of the callers. But that doesn't seem to be too bad actually. +1 Line 301: cls.metadataClass._putMetadata(metaId, meta) Line 302: Line 303: def setMetadata(self, meta, metaId=None): Line 304: return self._md.setMetadata(meta, metaId) -- To view, visit https://gerrit.ovirt.org/41847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia245c589ea6bc2cf9ac1b2b59b9073d1b5fc9595 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
