Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata objects ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG Commit Message: Line 9: When we are working directly with StorageDomainManifest objects we do Line 10: not want to produce Volume objects. Instead, we'll produce Line 11: VolumeMetadata objects. The interface between Volume and VolumeMetadata Line 12: is consistent (except that VolumeMetadata lacks functions that can only Line 13: be called when working with an SPM). > What about old callers of getVolumeClass()? They're working with StorageDomain objects and will get either BlockVolume or FileVolume as appropriate. Line 14: Line 15: Change-Id: Iacb2723c8ce2108b3e5ac2f35be2f59f083095e0 -- To view, visit https://gerrit.ovirt.org/44040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacb2723c8ce2108b3e5ac2f35be2f59f083095e0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
