Francesco Romani has posted comments on this change. Change subject: virt: run hook before_device_create on every device ......................................................................
Patch Set 2: Code-Review-1 -1 for visibility, I don't actually have strong feelings against this patch, but let's try to gather some data. Since you (correctly, thanks!) warned in the first place about performance loss, would you please run some benches and attach some data, to estimate how much we lose? We could think of a *new* hook which is given all the devices and it is invoked once, but this seems overkill. And yes, you could use a custom vNIC property. If you can avoid this, please do. -- To view, visit https://gerrit.ovirt.org/49182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07f8be2a8ff1889b22a780ce99f5333fb6bd3405 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
