Shu Ming has posted comments on this change. Change subject: '0' is a valid master version ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 848: pool.getMasterDomain(msdUUID=msdUUID, masterVersion=masterVersion) Line 849: return Line 850: Line 851: pool = sp.StoragePool(spUUID, self.taskMng) Line 852: if not hostID or not scsiKey or not msdUUID or (masterVersion == None): Adam, masterversion = 0 here will make "not masterVersion" to be true. And the pool.getPoolParams() will be called, tough the temporary pool file is not initialized yet. Line 853: hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams() Line 854: res = pool.connect(hostID, scsiKey, msdUUID, masterVersion) Line 855: if res: Line 856: self.pools[spUUID] = pool -- To view, visit http://gerrit.ovirt.org/7948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I736d917bfa7d3a5ac59cddcaf1a18846f53d85b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
