Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move getImageVolumes ......................................................................
Patch Set 11: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/44043/11/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 698: return self._md.setParentTag(puuid) Line 699: Line 700: @classmethod Line 701: def getImageVolumes(cls, repoPath, sdUUID, imgUUID): Line 702: return BlockVolumeMetadata.getImageVolumes(repoPath, sdUUID, imgUUID) Move up to Volume.getImageVolumes() Line 703: Line 704: def getMetaOffset(self): Line 705: return self._md.getMetaOffset() Line 706: https://gerrit.ovirt.org/#/c/44043/11/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 516: raise se.VolumeAccessError(volPath) Line 517: Line 518: @classmethod Line 519: def getImageVolumes(cls, repoPath, sdUUID, imgUUID): Line 520: return cls.metadataClass.getImageVolumes(repoPath, sdUUID, imgUUID) Move up to Volume.getImageVolumes() Line 521: Line 522: def setParentMeta(self, puuid): Line 523: """ Line 524: Set parent volume UUID in Volume metadata. This operation can be done -- To view, visit https://gerrit.ovirt.org/44043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
