Shu Ming has posted comments on this change. Change subject: removing cpuIdle ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm_api/vdsmapi-schema.json Line 4574: 'network': 'NetworkInterfaceStatsMap', Line 4575: 'disks': 'VmDiskStatsMap', 'monitorResponse': 'int', Line 4576: 'nice': 'int', 'elapsedTime': 'uint', '*cdrom': 'str', Line 4577: '*boot': 'VmBootMode','statsAge': 'float', 'cpuSys': 'float', Line 4578: 'cpuUser': 'float', A nit, why not keep the above line aligned with others with two or three data per line. Line 4579: 'acpiEnable': 'bool', 'timeOffset': 'uint', Line 4580: 'clientIp': 'str', 'pauseCode': 'str', 'memUsage': 'uint', Line 4581: 'username': 'str', 'session': 'GuestSessionState', Line 4582: 'appsList': ['str'], 'guestIPs': 'str', -- To view, visit http://gerrit.ovirt.org/7892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
