Nir Soffer has posted comments on this change. Change subject: v2v: _read_ovf_from_tar_ova use tarfile package ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50106/1/vdsm/v2v.py File vdsm/v2v.py: Line 915 Line 916 Line 917 Line 918 Line 919 Lets add a test for this function - before you improve it. You can add a tar file with small ovf file as test data, and check that this function returns the contents of the file. Another option it to generate the tarfile in a temporary directory during the test. I would use existing file since it requires less code and less likely to break. The test should also test invalid tar without ovf file. -- To view, visit https://gerrit.ovirt.org/50106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e027470f0ab283b3260fc02aafc01fe3debc95f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
