Nir Soffer has submitted this change and it was merged. Change subject: tests: Safer fake objects for indirection tests ......................................................................
tests: Safer fake objects for indirection tests When testing that old code is redirecting calls to new code, the fake recording classes should inherit from object instead of the real classes. Otherwise, the real methods may run, which may not be safe during the tests (unwanted side effects), or cause incorrect results. Fixing the inheritance revealed missing properties in the fake manifest and metadata classes, that worked using the real code properties. Change-Id: Ic9e4802077316cb49d4c9f8664507bfa3b552012 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/50029 Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke <[email protected]> --- M tests/sdm_indirection_tests.py 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9e4802077316cb49d4c9f8664507bfa3b552012 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
