Nir Soffer has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py File tests/functional/utils.py: Line 80: def getInstance(cls): Line 81: with cls._instanceLock: Line 82: if cls._instance is None: Line 83: cls._instance = VdsProxy() Line 84: return cls._instance > Nir means to override 'def __new__' afaik. Not so important Nir... this imp Please don't override __new__. Make the class private, and provide a function to access the single instance. We have same code in clientIF, should be removed. Line 85: Line 86: def start(self): Line 87: if _JSONRPC_ENABLED: Line 88: requestQueues = config.get('addresses', 'request_queues') -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1fd202566edd389f06d49876e5b83391686b53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
