Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: move refreshVolume ......................................................................
Patch Set 22: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/42003/22/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 542: cls.createMetadata(metaId, meta) Line 543: return meta Line 544: Line 545: def refreshVolume(self): Line 546: pass maybe worth adding a comment that we implement it in block for example? Line 547: Line 548: Line 549: class Volume(object): Line 550: log = logging.getLogger('Storage.Volume') -- To view, visit https://gerrit.ovirt.org/42003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5041428d8d2e73edc1aa1362fcea8801e5b9116 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
