Ryan Harper has posted comments on this change.
Change subject: Encapsulate vdsm-unregister into vdsm-tool function
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm-tool/register.py
Line 22: import subprocess
Line 23: from vdsm.tool import vdsm_tool_expose
Line 24:
Line 25: RHEL_PATH = '/etc/rhev-hypervisor-release'
Line 26: VDSM_UNREGISTER = '/usr/sbin/vdsm-unregister'
These should be in constants.py
Line 27:
Line 28: @vdsm_tool_expose("stop-vdsm-service")
Line 29: def stop_vdsm_service():
Line 30: """
Line 31: Stop vdsm service
Line 32: """
Line 33: if not os.path.exists(RHEL_PATH):
Line 34: os.system('/bin/systemctl --no-reload disable vdsmd.service')
Line 35: os.system('/bin/systemctl stop vdsmd.service')
systemctl should be part of constants.py
Line 36: else:
Line 37: try:
Line 38: subprocess.call(VDSM_UNREGISTER, shell=True)
Line 39: except OSError, e:
--
To view, visit http://gerrit.ovirt.org/4527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7348baeabbdcbb0c2da64170b6957430feaa1954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
