Nir Soffer has submitted this change and it was merged. Change subject: vm: enabling memory snapshot without disks ......................................................................
vm: enabling memory snapshot without disks Taking a memory snapshot of a VM without disks should be supported (or merely with Cinder/LUN disks for that matter). Hence, removing the early return on 'VM -> snapshot' in case 'newDrives' is empty. Instead, proper logging will be added on consecutive patches. Possible configurations and settings that lead to this flow: * Unchecking all the disks in the create snapshot dialog. * VM with only cinder disks. * VM without disks. Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Bug-Url: https://bugzilla.redhat.com/1287066 Signed-off-by: Daniel Erez <de...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/49535 Reviewed-by: Arik Hadas <aha...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Adam Litke <ali...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> --- M vdsm/virt/vm.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Verified Francesco Romani: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
