Antoni Segura Puimedon has posted comments on this change. Change subject: pep8ize vdsm_api ......................................................................
Patch Set 1: (1 inline comment) I would prefer that inline comment gone if it does not serve a very high purpose. Otherwise, I'm very glad to see the codebase increasingly deprived of has_key. .................................................... File vdsm_api/vdsmapi.py Line 51: while tokens[0] != '}': Line 52: key = tokens[0] Line 53: tokens = tokens[1:] Line 54: Line 55: tokens = tokens[1:] # : What is this inline comment useful for? Generally inline comments are not very much in the spirit of pep8. Line 56: Line 57: value, tokens = parse(tokens) Line 58: Line 59: if tokens[0] == ',': -- To view, visit http://gerrit.ovirt.org/8012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38418b2251ab67ad96325a2a474e1d03eddeabba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
