Martin Betak has posted comments on this change.

Change subject: virt: add run_async helper
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

Nice job! I really like the simplification over the previous implementations.

https://gerrit.ovirt.org/#/c/49570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 680:                 self.updateDriveIndex(drv)
Line 681: 
Line 682:         return [drv for order, drv in drives]
Line 683: 
Line 684:     def run(self, spawn=run_async):
this method didn't return anything before (it seems), do you utilize this new 
return value somewhere? cif/API.py?
Line 685:         try:
Line 686:             spawn(self._startUnderlyingVm)
Line 687:         except AsyncStartError as ex:
Line 688:             return response.error(ex.error)


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to