Nir Soffer has posted comments on this change. Change subject: sdm: Add create_volume job ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/create_volume.py File vdsm/storage/sdm/api/create_volume.py: Line 32: class Job(sdm_job.SdmJob): Line 33: def __init__(self, job_id, host_id, dom_manifest, vol_params): Line 34: super(Job, self).__init__(job_id, 'create_volume', host_id) Line 35: self.dom_manifest = dom_manifest Line 36: self.vol_params = _CreateVolumeParams(vol_params) Why not _VolumeParameters? Line 37: Line 38: def _run(self): Line 39: self.dom_manifest.validateCreateVolumeParams( Line 40: self.vol_params.vol_format, self.vol_params.parent_vol_id) Line 38: def _run(self): Line 39: self.dom_manifest.validateCreateVolumeParams( Line 40: self.vol_params.vol_format, self.vol_params.parent_vol_id) Line 41: Line 42: self.dom_manifest.acquireDomainLock(self.host_id) We can use now with dom_manifest.domain_lock(self.host_id) Line 43: try: Line 44: image_res_ns = sd.getNamespace(self.dom_manifest.sdUUID, Line 45: IMAGE_NAMESPACE) Line 46: with rmanager.acquireResource(image_res_ns, self.vol_params.img_id, -- To view, visit https://gerrit.ovirt.org/50221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches