Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir ......................................................................
Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 484: if os.path.exists(conffile): Line 485: config.read([conffile]) Line 486: Line 487: if os.path.exists(confdropin): Line 488: config.read(sorted(glob(confdropin + "/*.conf"))) sub directories configs will override values that are declared in main conf file. I mean, if we'll have vdsm.conf and vdsm.d/10-conf which declares something that already appears in vdsm.conf, it will override it. but I don't see any bad in that. this logic doesn't break current work with vdsm.conf which is great Line 489: Line 490: read_configs("vdsm") Line 491: Line 492: if __name__ == '__main__': -- To view, visit https://gerrit.ovirt.org/48317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
