Ala Hino has posted comments on this change. Change subject: gluster: Handle missing glusterfs-cli package ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/50363/4//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-12-12 17:40:31 +0200 Line 4: Commit: Ala Hino <ah...@redhat.com> Line 5: CommitDate: 2015-12-13 16:51:52 +0200 Line 6: Line 7: gluster: Warn about missing glusterfs-cli package > Please update the commit message - this is not about the warning, but about Done Line 8: Line 9: In 3.6 we introduced a dependency to glusterfs-cli. This is required in Line 10: order to get gluster volume info needed to get gluster backup servers Line 11: and replica related logic. Howevre, we found tht during upgrade, if https://gerrit.ovirt.org/#/c/50363/4/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 1588: except OSError as e: Line 1589: if e.errno != os.errno.ENOENT: Line 1590: raise Line 1591: return False Line 1592: return True > This means that gluster was found in the first time _glusterCommandPath.cmd Done https://gerrit.ovirt.org/#/c/50363/4/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 338 Line 339 Line 340 Line 341 Line 342 > We should check here if gluster exists. If it does not, log a big warning a Done Line 359: def _get_gluster_volinfo(self): Line 360: if not gluster_cli.gluster_exists(): Line 361: self.log.warning("Required glusterfs-cli package is missing " Line 362: "on this host. Please install the package " Line 363: "in order to use gluster storage") > This check must be done earlier. If gluster is not installed, there is no p Done Line 364: Line 365: volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname, Line 366: self._volfileserver) Line 367: return volinfo[self._volname] -- To view, visit https://gerrit.ovirt.org/50363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches