Nir Soffer has posted comments on this change. Change subject: lib: executor: report worker status in __repr__ ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/49722/4//COMMIT_MSG Commit Message: Line 7: lib: executor: report worker status in __repr__ Line 8: Line 9: To make the troubleshooting of stuck workers Line 10: easier, we extend Worker.__repr__ to report the Line 11: state, which could be 'discarded' or 'available'. Please update to reflect the current implementation. I think it will be useful to show the various logs we can get here. Line 12: Line 13: Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42 Line 14: Backport-To: 3.6 https://gerrit.ovirt.org/#/c/49722/4/lib/vdsm/executor.py File lib/vdsm/executor.py: Line 218: def __repr__(self): Line 219: return "<Worker name=%s %s%s at 0x%x>" % ( Line 220: self.name, Line 221: ("waiting" if self._callable is None Line 222: else "running %s" % self._callable), This is a good example when the ternary operation should not be used. It is better to create the string "waiting" and "running <task>" before formatting. Line 223: " discarded" if self._discarded else "", Line 224: id(self) Line 225: ) Line 226: -- To view, visit https://gerrit.ovirt.org/49722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
