Shahar Havivi has posted comments on this change. Change subject: v2v: extract specific classes for libvirt and ova ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py File vdsm/v2v.py: Line 303: def execute(self): Line 304: self._generate_disk_parameters() Line 305: self._prepare_volumes() Line 306: try: Line 307: self._proc = execCmd(self._command(), sync=False, > VERY minor nit Done Line 308: deathSignal=signal.SIGTERM, Line 309: nice=NICENESS.HIGH, Line 310: ioclass=IOCLASS.IDLE, Line 311: env=self.environments()) Line 309: nice=NICENESS.HIGH, Line 310: ioclass=IOCLASS.IDLE, Line 311: env=self.environments()) Line 312: Line 313: yield > Why not: The proc is accessible from other methods such as abort(). If we yeild the proc we need a proc member in the importVM. Line 314: finally: Line 315: self._teardown_volumes() Line 316: Line 317: def _get_disk_format(self): -- To view, visit https://gerrit.ovirt.org/49951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
