Dan Kenigsberg has posted comments on this change.

Change subject: pep8ize vdsm/vdsm entry point
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/vdsm
Line 116:     )
Line 117:     group = grp.getgrnam(constants.VDSM_GROUP)
Line 118:     assert ((constants.VDSM_USER in group.gr_mem
Line 119:              or pwd.getpwnam(constants.VDSM_USER).pw_gid == 
group.gr_gid),
Line 120:                 "VDSM failed to start: vdsm user is not in KVM group")
I hate to loose your acks ...
Line 121: 
Line 122: if __name__ == '__main__':
Line 123:     __assertVdsmUser()
Line 124:     os.setpgrp()


--
To view, visit http://gerrit.ovirt.org/8026
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c20b5dad7bf502e2862db14d6062ddc239ca3c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to