Dan Kenigsberg has uploaded a new change for review.
Change subject: tests: mark test_mkFloppyFs as broken
......................................................................
tests: mark test_mkFloppyFs as broken
test_mkFloppyFs fails quite often with
ERROR: Tests mkimage.mkFloppyFs creating an image and checking its content.
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testlib.py",
line 73, in wrapper
return f(self, *args)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
line 97, in wrapper
return f(*args, **kwargs)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/mkimageTests.py",
line 172, in test_mkFloppyFs
m.mount(mntOpts='loop')
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
line 225, in mount
return self._runcmd(cmd, timeout)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
line 241, in _runcmd
raise MountError(rc, ";".join((out, err)))
MountError: (32, ';mount:
/tmp/vdsm-mkimage-testswqsKjg/images/vmId_floppy.0478bd99cc3b39a408d863d4babd70bd.img:
failed to setup loop device: No such file or directory\n')
The floppy image might disappear by mkimage._commonCleanFs of a concurrent run
of the test.
Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3
Signed-off-by: Dan Kenigsberg <dan...@redhat.com>
---
M tests/mkimageTests.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/50484/1
diff --git a/tests/mkimageTests.py b/tests/mkimageTests.py
index ab2e4e9..c74166f 100644
--- a/tests/mkimageTests.py
+++ b/tests/mkimageTests.py
@@ -34,7 +34,7 @@
from nose.plugins.skip import SkipTest
from monkeypatch import Patch
from testlib import VdsmTestCase, permutations, expandPermutations
-from testValidation import checkSudo, ValidateRunningAsRoot
+from testValidation import brokentest, checkSudo, ValidateRunningAsRoot
from vdsm import udevadm
from vdsm.utils import execCmd, stopwatch
@@ -159,6 +159,8 @@
mkimage._decodeFilesIntoDir(self.files, self.workdir)
self._check_content()
+ @brokentest("mkimage._commonCleanFs of one run can remove floppy image "
+ "created by a concurrent one")
@ValidateRunningAsRoot
@permutations([[None], ['FSLABEL']])
def test_mkFloppyFs(self, label):
--
To view, visit https://gerrit.ovirt.org/50484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
