Milan Zamazal has posted comments on this change. Change subject: virt: tests: More testVideoXML tests ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50420/1/tests/deviceTests.py File tests/deviceTests.py: Line 303: """<video> Line 304: <model heads="2" ram="65536" type="qxl" vgamem="8192" vram="32768"/> Line 305: </video>"""] Line 306: ]) Line 307: def testVideoXML(self, dev_spec, video_xml): > Ok, fair enough. Now, question: how did you select the new testcases? Do we > how did you select the new testcases? Do we cover all branches now? Just a few representative cases (0, 1, all optional attributes). There is no need to explode the test with all possible combinations, the code is already covered. Line 308: video = vmdevices.core.Video(self.conf, self.log, **dev_spec) Line 309: self.assertXMLEqual(video.getXML().toxml(), video_xml) Line 310: Line 311: def testInterfaceXML(self): -- To view, visit https://gerrit.ovirt.org/50420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
