Nir Soffer has posted comments on this change. Change subject: storage: Add constants module to storage ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49544/5/vdsm/storage/storageConstants.py File vdsm/storage/storageConstants.py: Line 22: SECTOR_SIZE = 512 Line 23: Line 24: # This is the extension applied to FileVolume metadata files during the Line 25: # volume creation process. Line 26: ARTIFACT_FILEEXT = ".tmp" Are you should about the name? Way not TEMPORARY_SUFFIX? And we probably need similar constants for block storage, will be nice if we have both of them here. -- To view, visit https://gerrit.ovirt.org/49544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
