Ido Barkan has posted comments on this change. Change subject: Always propagate bonding mode to engine ......................................................................
Patch Set 5: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/49580/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-12-17 13:31:06 +0200 Line 6: Line 7: Always propagate bonding mode to engine Line 8: Line 9: Without patch the bond mode is not propagated if it's this Line 10: not equal to 0 (default) although engine expect it to be Line 11: propagated always Line 12: Line 13: Bug-Url: https://bugzilla.redhat.com/1276445 Line 11: propagated always always propagated. https://gerrit.ovirt.org/#/c/49580/5/lib/vdsm/kernelconfig.py File lib/vdsm/kernelconfig.py: Line 231: if "mode" not in normalized_opts: : normalized_opts["mode"] = '0' why is this change needed? kernelConfig has nothing to do with reporting to engine. https://gerrit.ovirt.org/#/c/49580/5/lib/vdsm/netinfo/bonding.py File lib/vdsm/netinfo/bonding.py: Line 83: Return non-empty options differing from defaults, excluding not actual or : not applicable options, e.g. 'ad_num_ports' or 'slaves'. function doc should be updated https://gerrit.ovirt.org/#/c/49580/5/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2668: test_bondmode_in_capabilities +1 for testing! but why not write a faster test in netinfoTests.py ? functional tests are slow and are meant to test cross layers integration. -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sagi Shnaidman <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sagi Shnaidman <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
